Add missing factories - Githubissues

erichard / elasticsearch-query-builder

Build query for an ElasticSearch client using a fluent interface

MIT License

39 stars 20 forks source link

Closed Ilyes512 closed 3 months ago

Ilyes512 commented 8 months ago

Add missing factory methods to src/Query/Query.php
Add missing factory methods to src/Aggregation/Aggregation.php
Applied code style linter
- I did re-enable use_nullable_type_declaration that is set to off by the symfony rule set. It would other wise remove null from parameter type hint when the default value was set to null.
Fixed a minor type I came across in a comment
Fixed 2 deprecations warnings in tests
Fixed 2 assertions in tests

Ilyes512 commented 3 months ago

@erichard If you got time... can we get this merged and released please?

erichard commented 3 months ago

@Ilyes512 Done ! Sorry for the delay I completly missed your PR