search

erichard / elasticsearch-query-builder

Build query for an ElasticSearch client using a fluent interface
MIT License
39 stars 20 forks source link

Add Set Field Method to GeoLocation Filter #6

Closed CraftLogan closed 4 years ago

CraftLogan commented 4 years ago

This method is needed because you need to pass a field name sometimes to search the correct geo distance field.

Thanks, Logan

erichard commented 4 years ago

Thanks @CraftLogan. I did not know my bundle was used outside my company :)

Just for the feedback. Did you try https://github.com/ongr-io/ElasticsearchDSL ?

CraftLogan commented 4 years ago

Hey @erichard, I have looked at the ElasticsearchDSL repo, which is more fleshed out than your package; however, I like the structure and syntax of your package better. I believe your package could be the go-to PHP elastic search query builder. To get to that stage, we should start adding a few tests and set up a documentation site. When I get some time in a few weeks, I might try to get some tests set up and work on a template for a documentation site. There are also a few filters that would need to be implemented like has_child and has_parent. This package has incredible potential!!!!

erichard commented 4 years ago

Thanks a lot for this feeback.

I created this package because I didn't like the developer experience of ONGR. I find it way too verbose.

Great if you are willing to help !

CraftLogan commented 4 years ago

Yeah no problem. Thanks Logan

erichard commented 4 years ago

I've started a full rewrite with tests in v2 branch