erichdongubler-mozilla / moz-webgpu-cts

An extremely fast (but opinionated) tool for working with WPT metadata while developing an implementation of WebGPU in a web browser.
Apache License 2.0
1 stars 2 forks source link

[meta] Servo support #106

Open sagudev opened 5 months ago

sagudev commented 5 months ago

Basic support for servo has landed in #92, but there are still some things we need before servo can move off #80 :

Also, when developing new webgpu features on servo I found useful to have (https://github.com/ErichDonGubler/moz-webgpu-cts/pull/80/commits/773f118522461d45bfd8dd5183fd8a3712c8965e) to only set new good expectations, or https://github.com/ErichDonGubler/moz-webgpu-cts/pull/80/commits/039200b6100133c7fadab40cfef04771960b4a9f to set only those that are reported (if we do partial run of WPT tests)

ErichDonGubler commented 5 months ago

I have yet to really go through each of the points in the OP, but: Partial runs are actually the motivation behind https://github.com/ErichDonGubler/moz-webgpu-cts/issues/25.

ErichDonGubler commented 5 months ago

Thinking things through more, @sagudev, you might be interested in the workflow that we're undertaking at Mozilla. We recently added the implementation-status: backlog property to all test cases (see upstream docs on metadata), and have incrementally removed it as we've determined tests are worth blocking on in CI. We now use both tier 2 and tier 3 of Firefox CI.

I'm currently calling the migration of a test from a less stable tier to a more stable tier by removing implementation-status: backlog a "promotion". We do experiments in promoting tests according to heuristics like "promote permanently PASSing tests" (already implemented), "promote tests that aren't observed to FAIL or CRASH" (to be implemented in #109), with more to come. The workflow then becomes:

  1. Run tests, and gather wptreport.json files.
  2. Run update-expected as desired for backlogged tests, and create a commit.
  3. Run update-backlog to tentatively promote tests. Commit and submit to CI as an experiment.
  4. Check tentatively promoted tests are successful in the above experiment. Where they are not, demote them, preferably with bugs in Bugzilla.

We consider using implementation-status: backlog to be valuable because: