erichdongubler-mozilla / treeherder-dl

An opinionated tool for downloading artifacts from Mozilla's CI ("Treeherder").
Apache License 2.0
0 stars 0 forks source link

BREAKING CHANGE: add task ID segment to local artifact path #27

Closed ErichDonGubler closed 5 months ago

ErichDonGubler commented 5 months ago

With 1.0.2/#21, I accidentally swapped the index of "identical" tasks with a run ID, but removed a distinguishing path segment between different tasks. The result is that treeherder-dl invocations would overwrite artifacts when there was more than a single task based on the same job. Oops! 😳

I don't think a counter-as-an-ID is as useful as the task ID itself. This will significantly lengthen the output path for artifacts, but I think it's the best option.

We cannot avoid a breaking change here; #21 should have been a breaking change, in retrospect, if we had done it correctly.