search

erichexter / twitter.bootstrap.mvc

nuget package to make bootstrap easy with mvc4
Apache License 2.0
248 stars 134 forks source link

"Confirm delete" page. #26

Closed jensj closed 11 years ago

jensj commented 11 years ago

Added a "Confirm delete" page which posts back to controller to perform delete of an object.

Rationale: GET requests should be idempotent.

erichexter commented 11 years ago

I added some comments to the pull request... its close, just need to clean the implementation up a little bit.

Eric Hexter

blog | http://Hex.LosTechies.com info | http://www.linkedin.com/in/erichexter

On Sun, Dec 2, 2012 at 1:44 PM, jensj notifications@github.com wrote:

Added a "Confirm delete" page which posts back to controller to perform delete of an object.

Rationale: GET requests should be idempotent.

You can merge this Pull Request by running:

git pull https://github.com/jensj/twitter.bootstrap.mvc master

Or view, comment on, or merge it at:

https://github.com/erichexter/twitter.bootstrap.mvc/pull/26 Commit Summary

  • Added confirm page for delete according to best practices.

File Changes

  • M src/Controllers/HomeController.cs.pp (13)
  • A src/Views/Shared/Delete.cshtml (24)

Patch Links

erichexter commented 11 years ago

I need to merge this in..

jensj commented 11 years ago

Not following, you ned me to do something?

erichexter commented 11 years ago

I did a bunch of refactoring and moving files around so I will just need to manually make these changes to the files to get this merged in.. Nothing you need to do.

Thanks, Eric

Eric Hexter

blog | http://Hex.LosTechies.com info | http://www.linkedin.com/in/erichexter

On Sat, Dec 22, 2012 at 1:20 AM, jensj notifications@github.com wrote:

Not following, you ned me to do something?

— Reply to this email directly or view it on GitHubhttps://github.com/erichexter/twitter.bootstrap.mvc/pull/26#issuecomment-11634688.

serra commented 11 years ago

I'll do this, need to do it anyway for the delete code template.

serra commented 11 years ago

@jensj - please close this pull request in favor of #65; files got renamed and somewhere along the way and your commits "got lost" (at least I couldn't find them quick enough).

jensj commented 11 years ago

Sure, no problem.