erichexter / twitter.bootstrap.mvc

nuget package to make bootstrap easy with mvc4
Apache License 2.0
248 stars 134 forks source link

Template review: code templates should match the default scaffolding #29

Closed serra closed 9 years ago

serra commented 11 years ago

I'll use this pull request to port back some changes I made to the templates.

Notes

Depends on pull #65 (confirm delete)

Tasks

erichexter commented 11 years ago

so.. what would make it easier... creating a sample project that can run with the files before they are transformed into the .pp extensions.. so we can develop this inline and extract the package? Eric Hexter

blog | http://Hex.LosTechies.com info | http://www.linkedin.com/in/erichexter

On Wed, Dec 5, 2012 at 4:55 AM, Marijn van der Zee <notifications@github.com

wrote:

ime consu

serra commented 11 years ago

Sounds good. Such a project could also serve to "communicate" the goals and concerns of the project too (see #27). E.g.:

erichexter commented 11 years ago

I created a separate nuget for the templates..

as far as making it easier to back port changes.. this is the process you can use

modify the templates your using.. copy them into the bootstrap folder from a separate vs instance run the build.ps1 from the nuget console.. then do a install-package for the .templates package.

you can also automate this process like i did in the test\endtoend\tests.ps1 file.. I run that from a nuget console in a separate instance of vs and I can easily try out the packages that the build.ps1 creates in a new solution.

serra commented 11 years ago

That would work. I'll give have a look at it somewhere in the next couple of weeks. My first goal would be to make sure the templates exactly match their corresponding defaults in ~/Views/Shared.

Nice work!

erichexter commented 11 years ago

should i merge this or are you just reviewing it?

serra commented 11 years ago

I'd like to get all tasks checked before you merge. I'll reopen when done. Code templates are useful, but only if they match the default scaffolding.

And don't produce annoying compile errors, that's a big turn-off for me ATM.

serra commented 11 years ago

@erichexter @MisterJames please consider accepting this pull, or add some feedback for me, so I can approve it. It's kind of blocking further improvements; e.g.#79 #89.