search

erichexter / twitter.bootstrap.mvc

nuget package to make bootstrap easy with mvc4
Apache License 2.0
248 stars 134 forks source link

Align package naming with sirkirby's `twitter.bootstrap.mvc` package #61

Closed serra closed 9 years ago

serra commented 11 years ago

The package naming used by sirkirby's package twitter.bootstrap.mvc and erichexter's package twitter.bootstrap.mvc4 is confusing.

I think it would be in everybody's best interest to get this sorted out quickly. The sooner, the better. considering both packages are getting some traction (5k+ downloads in several months).

Chris Kirby (a.k.a. sirkirby at nuget & github maintains the twitter.bootstrap nuget package (80k+ downloads), on which erichexter's twitter.bootstrap.mvc4 has a dependency. sirkirby also maintains the twitter.bootstrap.mvc package, which adds bundling and minification for twitter.bootstrap assets to mvc4 projects.

I'm developing an MVC4 app and want to add Twitter Bootstrap. Do I ...

PM> Install-Package twitter.bootstrap.mvc4

OR

PM> Install-Package twitter.bootstrap.mvc ?

From what I understand from both projects, by inspecting sirkirby's code and readme and erichexter's code and documentation, the projects only have small overlap: the bundling and minification, and the targeting of mvc4. erichexter's project adds more functionality and is more opinionated. Another difference is the dependencies both projects take.

I think both package meet a need: sirkirby's package targets a developer that only wants to quickly add twitter.bootstrap assets whereas erichexter's package targets a developer that wants more.

I hope you guys don't mind raising this issue; some might consider it nitpicking but I don't and I hope the effort I put in writing this issue reflects this. I can think of many ways to resolve this, but it's probably best to leave it up to eric and chris.

serra commented 11 years ago

I've open also opened issue 7 in sirkirby/twitter-bootstrap-nuget

erichexter commented 11 years ago

I looked through the twtitter.bootstrap.mvc package and the bundling in .mvc4 is opinionated as well. I will have a conversation with him and see what if anything he would like to do with it. Based on how I want the bundling to work and bring in the additions of the validation shim.

Eric Hexter

blog | http://Hex.LosTechies.com info | http://www.linkedin.com/in/erichexter

On Wed, Jan 30, 2013 at 3:45 AM, Marijn van der Zee < notifications@github.com> wrote:

I've open also opened issue 7https://github.com/sirkirby/twitter-bootstrap-nuget/issues/7in sirkirby/twitter-bootstrap-nugethttps://github.com/sirkirby/twitter-bootstrap-nuget

— Reply to this email directly or view it on GitHubhttps://github.com/erichexter/twitter.bootstrap.mvc/issues/61#issuecomment-12881741.