search

erichexter / twitter.bootstrap.mvc

nuget package to make bootstrap easy with mvc4
Apache License 2.0
248 stars 134 forks source link

Support for Vertical/Horizontal Breaks in Navbar #62

Closed MisterJames closed 11 years ago

MisterJames commented 11 years ago

Added property to NamedRoute to allow composition of break in menu. Added overloads to accept the flag in the configuration extensions. Updated navigation extenstions to evaluate and build appropriate tags. Updated samples.

MisterJames commented 11 years ago

Just a quick note...the git breakdown of my change makes it look like I did a lot more to the code than I actually did. I think it's just fussy because I extracted the method on the child UL menu builder.

Other than that the changes are subtle. Here's the working change from the local package build with breaks in both the menu and the drop down:

Capture

Cheers.

MisterJames commented 11 years ago

Also a fix in there for missing the KeyAttribute, and a fail over for folks that don't attribute primary keys (common in EF code first).

erichexter commented 11 years ago

looks like this has a conflict with the areas support I just put in. Can you merge and resubmit ?

MisterJames commented 11 years ago

Will do, I'll address it in the AM.

Cheers.

MisterJames commented 11 years ago

Can you give it a try again? Looks like I've got it sorted. Cheers.