search

erichexter / twitter.bootstrap.mvc

nuget package to make bootstrap easy with mvc4
Apache License 2.0
248 stars 134 forks source link

Controller alert methods should be extension methods rather than BootstrapBaseController #86

Open jarrettv opened 11 years ago

jarrettv commented 11 years ago

I suggest Attention, Success, Information, and Error are made extension methods.

erichexter commented 11 years ago

I am cool including this as a pull request.

On Wed, Mar 20, 2013 at 3:23 PM, Jarrett Vance notifications@github.comwrote:

I suggest Attention, Success, Information, and Error are made extension methods.

— Reply to this email directly or view it on GitHubhttps://github.com/erichexter/twitter.bootstrap.mvc/issues/86 .

serra commented 11 years ago

:+1:

I'm not sure what the Update-Package twitter.bootstrap.mvc4 will do if BootstrapBaseController is unmodified. It might remove the file, possibly breaking client code. Please check this and handle it gracefully.

erichexter commented 11 years ago

So let me rephrase my support for this. Move the existing logic into extension methods and change the existing controller base to call these from the existing helper methods. On Mar 21, 2013 4:11 AM, "Marijn van der Zee" notifications@github.com wrote:

[image: :+1:]

I'm not sure what the Update-Package twitter.bootstrap.mvc4 will do if BootstrapBaseController is unmodified. It might remove the file, possibly breaking client code. Please check this and handle it gracefully.

— Reply to this email directly or view it on GitHubhttps://github.com/erichexter/twitter.bootstrap.mvc/issues/86#issuecomment-15225965 .