erichgoldman / add-url-to-window-title

A Chrome/Firefox addon which will put the web page address (URL) into the window's title. Useful for customizing KeePass's auto-type
GNU General Public License v3.0
74 stars 13 forks source link

Enable Multiprocess Firefox support (e10s) #16

Closed lieryan closed 5 years ago

lieryan commented 7 years ago

Currently, installing add-url-to-window-title addon will disable multiprocess on Firefox Stable (Firefox 50).

Test procedure:

  1. On about:config, created new boolean entry browser.tabs.remote.force-enable=true
  2. Enabled add-url-to-window-title addon and restart

Initial result, things seems to be working correctly:

  1. URL is shown on title bar
  2. Moving to a different tab, the URL part changes as expected
  3. Moving to a different window, the URL are shown correctly for each window
  4. Opening a new tab then opening a site, window title updates correctly
  5. Navigating between pages on different domain works

Tested Platforms:

erichgoldman commented 7 years ago

Hello @lieryan I plan to rewrite the entire extension over the next few months as a WebExtension since that is the new way. Currently, my extension uses the old framework so it will not be compatible with multi-process.

I currently have no timeline for this, but will announce when that time comes.

e00E commented 7 years ago

Bumping as a reminder for you @erichgoldman . Your addon is very useful and I would love to use it with firefox multi process.

lieryan commented 7 years ago

@erichgoldman do you have any progress on porting add-url-to-window-title to e10s?

For the moment, I had written my own rewrite/port of add-url-to-window-title to webextension/e10s. It is a barebone implementation and hardcoded with my personal/preferred configuration, but I'm publishing it on Github in case anyone might find it useful.

erichgoldman commented 7 years ago

@lieryan - took a look very cool. I regret that this keep getting pushed to the back burner. I think the logic will generally port, the only pain point is that you lose the built in config management with Chrome-style plugins.

alerque commented 7 years ago

@e00E Just a note that you can force multi-process mode with this extension enabled. The system think this extension will be a blocker but if you force the multi-process flag it doesn't actually cause any trouble. I've been using it for a couple months successfully.

That being said the rewrite for the web WebExtension system is still necessary for other reasons and I'll be waiting for it here. Thanks for the dev work on this @erichgoldman.

monk-time commented 7 years ago

There's a simple WebExtension replacement: TitleURL

erichgoldman commented 5 years ago

I have recently started the porting efforts. I am starting with Chrome since the API is a bit easier to work with and my main browser is non Vivaldi. I am investigating if I can just use one code base and test the browser for any API differences. I just finished some quick testing tonight in Chrome. Most of the content script is the same. In turns out that options management is actually easier in Chrome WebExtensions.

I need to determine how I am going to setup branches or if I will make a new repo, but I will try to provide some beta releases here before worrying about posting to official repos. I also need to learn new testing frameworks since the old tests were dependent upon the old Selenium IDE that worked directly in FireFox.

erichgoldman commented 5 years ago

Hello @lieryan , I have updated the extension to work with modern Firefox, please download from AMO and let me know if it works for you or if there are bugs.

lieryan commented 5 years ago

@erichgoldman sounds cool, I'll take a look at it and play with it over the next few weeks. I will let you know if I had issues.

lieryan commented 5 years ago

Seems to be working well from what I can see so far. The only thing that currently prevent me from retiring my reimplementation and permanently switching back to this is to have an option to show the protocol (e.g. https://) in the URL, to avoid autotyping to the http:// version of a site.

I'll see if I can make some time to make a PR for it.

I'll consider this issue completed for now.

erichgoldman commented 5 years ago

I am going to open an issue for this, on https://github.com/erichgoldman/add-url-to-window-title/blob/web-extension/managetitle.js#L204 it is calling document.URL which I believe should include the protocol.