search

erichgoldman / add-url-to-window-title

A Chrome/Firefox addon which will put the web page address (URL) into the window's title. Useful for customizing KeePass's auto-type
GNU General Public License v3.0
74 stars 13 forks source link

Switch to jmp and add Pale Moon support #17

Closed JustOff closed 7 years ago

JustOff commented 7 years ago

Could you please switch to jpm and add Pale Moon support?

I've built your add-on with jpm and it works well!

erichgoldman commented 7 years ago

Please note, since this is iteration using the old addon-sdk is not supported, I may not recompile and submit on the Mozilla website.

JustOff commented 7 years ago

Thank you for support and remarks! Since you are not going to post update to AMO I probably would have to keep the fork for Pale Moon users, just to provide the binary xpi. Can I retain the logo and name from your original add-on for it (I have no plans to publish this fork on AMO)?

erichgoldman commented 7 years ago

A full new version will eventually be released.

You may distribute and fork the software consistent with the license. I believe the best practice would be to fork it and give it a new name, e.g., autt-pm or something; this will avoid confusion with the official release.

I may create a release to AMO if I have some time to test and make sure it passes all tests once I switch to JPM, etc.

erichgoldman commented 7 years ago

I submitted an update to AMO since this was small and I was able to get jpm installed and going in under an hour - I imagine it will get approved. Was able to compile locally and all my existing selenium ide tests worked. Check AMO, if there are any issues I will comment here.

JustOff commented 7 years ago

Thank you so much! When new version that built with jpm will be published on AMO, no fork will be needed anymore.