Add a flag fetch_models to specify the way to encode NDB keys

erichiggins / gaek

A collection of useful tools for Google App Engine.

MIT License

16 stars 6 forks source link

Closed onufryk closed 7 years ago

onufryk commented 8 years ago

Added a boolean flag fetch_models to the constructor of NdbEncoder. The flag specifies the way to encode ndb.Key properties:

fetch_models=True (default value): the encoder will get the full entity by its key from the datastore and encode it;
fetch_models=False: the encoder will encode the ndb.Key as a tuple of (kind, id) pairs. No additional datastore read operations will be performed.

Example of usage: ndb_json.dump(data, dump_file, indent=2, sort_keys=True, fetch_models=False)

onufryk commented 7 years ago

Thanks for great review @erichiggins . Great comments with regard to open-source nature of the project.

Addressed all of them except the last one.

onufryk commented 7 years ago

@erichiggins rebased and simplified the code, also, added a section to README