erichlof / THREE.js-PathTracing-Renderer

Real-time PathTracing with global illumination and progressive rendering, all on top of the Three.js WebGL framework. Click here for Live Demo: https://erichlof.github.io/THREE.js-PathTracing-Renderer/Geometry_Showcase.html
Creative Commons Zero v1.0 Universal
1.94k stars 177 forks source link

Remove ' type: ' from demo-specific uniforms #67

Closed svnkomo closed 2 years ago

erichlof commented 2 years ago

@SakhileV Thank you Sakhile! I hadn't gone over the three.js docs in a long while, and somewhere along the way, I guess they stopped requiring the "type" keyword when defining demo-specific shader uniforms.

I am going to go through all of the other 20 or so demos and make similar changes. Anything that reduces code - I'm all for it!

Thanks again for the heads-up and your PR. :) -Erich