search

ericholscher / django-crawler

A crawler using the Django Test Client
http://django-crawler.readthedocs.org
30 stars 10 forks source link

Update for Django 1.3 staticfiles compatibility #2

Closed acdha closed 13 years ago

acdha commented 13 years ago

28f5c8beabe63c5f154c967516dcc5e67d371e51 avoids outright errors when crawling a site which uses Django 1.3's staticfiles package but doesn't provide a way for us to verify file existence. We could either use the same finders() call which the serve view has to simply verify that a file can be located or find some way to enable insecure=True before requesting static content.

ericholscher commented 13 years ago

Interesting. This should go ahead and go in master if it's actively breaking 1.3 sites.

I don't have a strong preference on the second point. Seems that setting insecure would require some kind of monkey-patching, but that's probably fine in this case.

acdha commented 13 years ago

It doesn't quite break 1.3 sites but you get an ImproperlyConfigured exception per request so it generates a ton of noise. Want me to merge it into master?

Chris

On Tue, Mar 29, 2011 at 4:29 PM, ericholscher reply@reply.github.com wrote:

Interesting. This should go ahead and go in master if it's actively breaking 1.3 sites.

I don't have a strong preference on the second point. Seems that setting insecure would require some kind of monkey-patching, but that's probably fine in this case.

Reply to this email directly or view it on GitHub: https://github.com/ericholscher/django-crawler/issues/2#comment_932994

ericholscher commented 13 years ago

Sure. We don't use it at Urban Airship, so I haven't been doing a good job of maintaining it. Please make it kick ass :)