search

ericjang / svd3

Fast singular value decomposition, diagonalization, QR decomposition of 3x3 matrices.
MIT License
149 stars 19 forks source link

unicode quotes and float conversions #4

Closed nlguillemot closed 8 years ago

nlguillemot commented 8 years ago

I replaced the fancy “” quotes with ascii " quotes, for better compatibility with editors and compilers (visual C++ was complaining).

I also fixed a few places where visual C++ was complaining about implicit double->float conversions.

I fixed some double->float conversions using fabsf and fmaxf, which are c99. We can switch them if you want to support older versions of C for whatever reason.

ericjang commented 8 years ago

Cool, thanks very much!