search

erickahmed / iceberg

Iceberg is a virtual FPGA computer built from scratch using Systemverilog
GNU General Public License v3.0
6 stars 2 forks source link

File names and locations #5

Open AdamLaine opened 1 year ago

AdamLaine commented 1 year ago

@erickahmed I propose a small thing to do to simplify the process for a lot of people. Sorry, but the file names and locations of the files are a little bit of a mess. In any case we are now checking for the bugs, so any changes are better now than later, so I propose to group the files, some of them to rename and even some of them to delete or return to the normal functionality (see /gates/xnor.v to understand what I mean). In such a way we also don't need to write separate testbenches for every file, but just to the group to test. Though there will be a problem that this proposition will break a lot of dependencies. If you agree, I'll do it and repair possible dependency failures (or postpone some of them if a file needs a complete redoing).

erickahmed commented 1 year ago

Actually I thought about it, and I agree that the file structure is a bit messy Go ahead with the necessary changes, I won't push anything meanwhile, and continue my work after I've pulled the new directories (so there won't be a giant merge conflict)

And yes, this will be more efficient if it means that we need less testbenches

AdamLaine commented 1 year ago

@erickahmed May I ask you about the naming I have proposed in the PR? I would like to know what do you think. And if yes, in the next PR I'll upload maybe some prototype test benches with the renamed files.

erickahmed commented 1 year ago

@SamReiCooper I actually like it more than the previous naming convention I used, the names are far more intuitive now! Also I wrote some testbenches but I had some weird issues with icarus-verilog (but it's probably something wrong with the way I reinstalled it). I'm going to do some test bench prototypes as well when I do resolve this thing