search

erickahmed / iceberg

Iceberg is a virtual FPGA computer built from scratch using Systemverilog
GNU General Public License v3.0
6 stars 2 forks source link

File names and locations #6

Closed AdamLaine closed 2 years ago

AdamLaine commented 2 years ago

Issue #5 @erickahmed Ok, I've grouped the files and I've corrected xnor16.v and nor16.v (they both had wrong functions inside). I ask you not to merge this PR yet, though. I've understood your naming policy, but I would like to propose to change it as and8way16, for example, I understood that it meant "and 8 input 16 bit each", but it came only after I've read the code. My proposition is and_in8_16bit or some other similar naming scheme (just and8_16bit is also an option). Tell me your thoughts. P.S. I'm sincerely sorry I've screwed up with the push, I have forgotten to create a new branch (I promise all the future PRs will be with the new branch) P.P.S. also due to the naming question I haven't started yet resolving dependencies

erickahmed commented 2 years ago

Btw it's ok, I just merged it in the main, we can always revert if there's any issue and re-push on another branch, so really no problem @SamReiCooper :) We will resolve dependencies directly in the main at this point I guess, then after we finish we will start using different branches (tell me if you agree with this)

erickahmed commented 2 years ago

PS: I like how you organised everything, it's much more easier to navigate the gates folder now