search

ericklein / air_quality

displays and logs local indoor and outdoor weather and air quality information
MIT License
0 stars 0 forks source link

post_dweet() Ethernet support #45

Closed ericklein closed 1 year ago

ericklein commented 2 years ago

post_dweet() has WiFi connection check but not for Ethernet. It might be better to say we need a generic handler to check Internet status?

disquisitioner commented 2 years ago

Good point. We have two physical device configurations via #define for WiFi and wired, and then one global state variable that says whether there's an active connection or not that gets used in an if test inside that compiled code. I'll take a look at ways to make that more straightforward given there are few generalizable functions that could be called independent of WiFi vs. wired.

ericklein commented 2 years ago

Closing this is dependent on headless execution, which is currently not working. I'll work on the headless issue as a branch from master.

disquisitioner commented 2 years ago

I think this should work now given the introduction of a generalized networking interface that handles WiFi and Ethernet connectivity identically. Will be good to test to make sure that's the case, though.

disquisitioner commented 2 years ago

The recent generalization of the networking code (via aq_network.cpp) enabled post_dweet() and post_influx() operations with Ethernet as well as on WiFi. This bug is therefore fixed, though it would be good to test it with working Ethernet hardware (hard wired, not WiFi).