erickok / ratebeer

RateBeer for Android app
GNU General Public License v3.0
22 stars 7 forks source link

Can't upload Beer Rating #26

Closed FergusNelson closed 8 years ago

FergusNelson commented 8 years ago

Hi,

I keep getting an error when attempting to upload a beer rating. The app suggests that maybe i need a better internet connection, but i dont think this is the problem. I know RB can be slow at times , so maybe you need to set a longer timeout maybe? either that or RB is returning an error code.

erickok commented 8 years ago

I have had lots of poor performance problems myself lately, where RB is too slow or responding with errors. There isn't too much I can do about it but I will try if a longer timeout request helps.

FergusNelson commented 8 years ago

Hi Eric,

Some more information on this. I think the app had been logged out, or at least the access token that the app had cached / saved had been invalidated on the server side. Perhaps the app isn't handling a 401/403 response status code from the server and invalidating the saved token. In this state the app seemed to be functioning normally except for upload.

Many thanks

erickok commented 8 years ago

I am of the same belief that it is the login token that is invalidated by the server, but the server does not provide any feedback on this at all. 😠 I have already tried to invalidating the cookies manually but apart from forcing a new login now and then (which is very random and incomplete) I have not found a reliable solution yet. To be continued.

erickok commented 8 years ago

Should be fixed in 7e6ef9d843bcb3012d23964a889ee5d0a662d21a and so in the next 2.1 release.