search

erickok / transdroid

Manage your torrents from your Android device
GNU General Public License v3.0
1.28k stars 201 forks source link

Active torrents filter displays all torrents #490

Closed dpsenner closed 5 years ago

dpsenner commented 5 years ago

Steps to reproduce

When talking to rtorrent transdrone displays all torrents when selecting "Status"->"Active" instead of just the torrents that are active.

What would You expect to happen instead?

transdrone should display only the active torrents as reported in rtorrent, ruTorrent, etc.

dpsenner commented 5 years ago

Might be related to issue #55.

erickok commented 5 years ago

What do you consider an 'active torrent'? Transroid considers all torents active if they are in seeding or downloading state, regardless of any actual transfer (connected peers) going on. If you prefer to only see torrents in this view that are currectly having > 0kB/s up- or download, use the 'Treat dormant torrents as inactive' option under Settings -> System.

dpsenner commented 5 years ago

Awesome, a configuration switch that i didn't know it exists. :+1: Thanks!

dpsenner commented 5 years ago

Unfortunately, the configuration option has an unintended negative side effect. Currently there is a torrent being downloaded but it is not shown in "Downloading" because it has no seeders (0Kb/s transfer speed). This is unexpected for me and therefore I am reopening this issue. I expect all unfinished torrents to be listed in "Downloading" regardless of transfer speed, otherwise there is no way to know which torrents have no seeders.

erickok commented 5 years ago

I'm afraid that you have to be a bit more precise then what you want to see in an 'active torrents' filter. All unfinished torrents AND all seeding torrents ONLY if they are actively having leechters (> 0kB/s)?

dpsenner commented 5 years ago

Coming from rtorrent, active torrents are to me torrents that satisfy any of the following conditions:

These conditions could be OR'ed.

Assuming that my preference is exotic, is it feasible to add a configuration option that allows users to have fine grained control over which of the above conditions are checked when finding active torrents? I.e. something like:

When checking for torrents that should be shown in the active tab:

(include | exclude | ignore) torrents with download speed > 0 (include | exclude | ignore) torrents with upload speed > 0 ...

Include marks a torrent to be shown. Exclude marks a torrent to be hidden. Ignore is a noop and as such ignores the condition but other conditions are eventually checked.

erickok commented 5 years ago

I decided not to go ahead with this - as it stand users seem very happy with the current sorting and filtering, and as such I am not inclined to change anything. Sorry!

dpsenner commented 5 years ago

Thanks for sharing your opinion and the efforts you are donating to the users.