erickok / transdroid

Manage your torrents from your Android device
GNU General Public License v3.0
1.28k stars 201 forks source link

qBittorrent: can't set file priority to Priority.Normal aka qBittorrent's High #619

Closed xifer closed 1 year ago

xifer commented 1 year ago

When I try to change file priorities from any other priority to Priority.Normal (two out of three checks) nothing happens.

I think the file priorities are incorrect for Normal on 3.2.x+.

https://github.com/erickok/transdroid/blob/master/app/src/main/java/org/transdroid/daemon/adapters/qBittorrent/QBittorrentAdapter.java#L378 should be 1,6,7 for Normal, High, Maximum (not 1,2,7).

I think likewise for https://github.com/erickok/transdroid/blob/master/app/src/main/java/org/transdroid/daemon/adapters/qBittorrent/QBittorrentAdapter.java#L898 because Maximum priority files have the same dark green when previously set (in app or WebUI) High.

This is according for: version >=30200: https://github.com/qbittorrent/qBittorrent/wiki/WebUI-API-(qBittorrent-v3.2.0-v4.0.4)#get-torrent-contents https://github.com/qbittorrent/qBittorrent/wiki/WebUI-API-(qBittorrent-4.1)#get-torrent-contents

But the current 1,2,7 was correct for 3.1.x: https://github.com/qbittorrent/qBittorrent/wiki/WebUI-API-(qBittorrent-v3.1.x)#get-torrent-contents