erickok / transdroid

Manage your torrents from your Android device
GNU General Public License v3.0
1.28k stars 201 forks source link

pull621 #622

Closed 1265578519 closed 1 year ago

1265578519 commented 1 year ago

https://github.com/erickok/transdroid/pull/621

1265578519 commented 1 year ago

https://github.com/erickok/transdroid/blob/master/app/src/main/java/org/transdroid/daemon/adapters/bitComet/BitCometAdapter.java#L173

                    // Request to add a torrent by URL
                    String magnetUrl = ((AddByMagnetUrlTask) task).getUrl();
                    makeUploadUrlRequest(log, "/panel/task_add_httpftp_result", magnetUrl);
                    return new DaemonTaskSuccessResult(task);

magnetUrl = /panel/task_add_magnet_result

bwitt commented 1 year ago

I think you meant change that line to be makeUploadUrlRequest(log, "/panel/task_add_magnet_result", magnetUrl); but I can't seem to find API docs for bitComet and I don't have an instance to test. do you know where the docs are?

1265578519 commented 1 year ago

I think you meant change that line to be but I can't seem to find API docs for bitComet and I don't have an instance to test. do you know where the docs are?makeUploadUrlRequest(log, "/panel/task_add_magnet_result", magnetUrl);

f12 image

image

image

task_add_httpftp It is used for http download and pro advanced optional functions such as custom cookies and User-Agent Although I test task_add_httpftp it to support Magnet Link at the same time, I thought it should be more friendly to use task_add_magnet image

bwitt commented 1 year ago

@1265578519 sorry I didn't ask earlier: what was the issue you were reporting here? what's not working? is it that adding magnet links to bitcomet doesn't work? do you have an example link that doesn't work?

1265578519 commented 1 year ago

@1265578519 sorry I didn't ask earlier: what was the issue you were reporting here? what's not working? is it that adding magnet links to bitcomet doesn't work? do you have an example link that doesn't work?

I use torrent url, it not work

https://dl.dmhy.org/2022/10/21/febe71baebff2ae0d7b6478c795ae37c5bbcac21.torrent

He need to use Bitcomet api /panel/task_add_magnet_result post torrent url. transdroid v2.5.22 uses /panel/task_add_httpftp_result, Bitcomet will only download torrent file, not dl torrent contain video files.

bwitt commented 1 year ago

thanks!