search

erickok / transdroid

Manage your torrents from your Android device
GNU General Public License v3.0
1.28k stars 201 forks source link

Dont show stop button on Bitcomet #635

Closed bwitt closed 5 months ago

bwitt commented 1 year ago

Remove bitcomet from the supportsStoppingStarting so we don't show an extra stop button.

Torrent stopped: bitcomet stopped

Torrent started: bitcomet started

Fixes https://github.com/erickok/transdroid/issues/634

erickok commented 1 year ago

I see I never implemented a start/stop (though I did for start all/stop all) so I guess BitComet doesn't support it?

bwitt commented 1 year ago

the problem is that Bitcomet only supports stop/start and not pause/resume; transdroid doesn't handle that case well (supportsStoppingStarting really means 'supports stopping and starting in addition to pausing and resuming'). I was thinking if we merged this change, we should open a new issue about only showing stop/start buttons if the client only supports stop/start and not pause/resume (since that's a larger change).

if we were to fix the non-functioning stop button, it would merely duplicate the resume button and I was thinking that's probably worse than simply not having the extra button at all.

erickok commented 1 year ago

Yes indeed Transdroid only supports resume/pause or resume/pause/stop/start. If a client (like bitcomet) doesn't support resume/pause/stop/start we just show only resume/pause (even though the client uses the naming start/stop). So this pr is fine. I was just confused because in my code (from so long ago...) I do see I implemented stopAll/startAll as well as pauseAll/resumeAll.

bwitt commented 1 year ago

@erickok thanks, sounds like this can be merged?