added a few more examples. added a poll_some method which exposes the nitems parameter

erickt / rust-zmq

Rust zeromq bindings.

Apache License 2.0

900 stars 194 forks source link

added a few more examples. added a poll_some method which exposes the nitems parameter #186

Closed dysn closed 7 years ago

rotty commented 7 years ago

Thanks for the multiple examples, and sorry for not getting back to you sooner! I'll do a more detailed review of your commits, but two things up front:

The poll_some change is not needed, I think -- you can use rust's slicing syntax to pass in a part of the poll item array, e.g., zmq::poll(&mut items[0..1], -1)
I'd prefer pull requests not containing merge commits, as it clutters git history -- could you rebase on current master, also eliminating the poll_some change?

ghost commented 7 years ago

@dysn Have you test syncpub and syncsub passed? Please look at #192 and give me a hand.

rotty commented 7 years ago

I've now integrated your work, thanks for your contribution! I've taken the liberty to apply the following changes to your PR:

Remove your poll_some commit, as that method is superfluous (as already noted by me and @birkenfeld ).
Eliminate the merge request -- please always submit pull requests without merge commits (i.e., rebased).
Run the new code through rustfmt, as there was quite a bit of inconsistent use of whitespace in them.