erickt / rust-zmq

Rust zeromq bindings.
Apache License 2.0
900 stars 194 forks source link

zmq-sys: Remove redundant `link` attribute #197

Closed rotty closed 5 years ago

rotty commented 7 years ago

As we use pkg-config by way of the metadeps crate, we do not need to specify the library name in the source.

This gets rid of the "redundant linker flag" warning when building zmq-sys; fixes #196.

See also: https://github.com/Rust-SDL2/rust-sdl2/issues/615

kpcyrd commented 5 years ago

An easy workaround (untested) could be:

#[cfg(target_os="windows")]
mod windows {
    #[link(name = "zmq")]
    extern {}
}
rotty commented 5 years ago

This issue seems to have disappeared on its own, see #196.