search

erickt / rust-zmq

Rust zeromq bindings.
Apache License 2.0
887 stars 189 forks source link

Added handshake socket event types #255

Closed sdbondi closed 5 years ago

sdbondi commented 5 years ago

Added socket event types as defined here:

https://github.com/zeromq/libzmq/blob/9bee21b364f540fad0e49040931d6846c1492178/include/zmq.h#L447

rotty commented 5 years ago

This requires libzmq 4.3.0 or greater, if I read the git history of libzmq correctly. I think it's OK to bump that requirement on the master branch, but that means the next release cut from master must be 0.10.0. I don't want to require libzmq upgrades on semver-compatible releases, but this policy is not yet documented.

I've added #260 regarding that issue, and will defer merging this pull request until I get the documentation cleared up regarding minimum versions for each zmq release .

rotty commented 5 years ago

Actually, as it doesn't require a libzmq 4.3 at compile time, just to use the new socket types, I'll merge right away.

rotty commented 5 years ago

Thanks for your contribution!