search

erickt / rust-zmq

Rust zeromq bindings.
Apache License 2.0
886 stars 189 forks source link

Check for deallocation in `message_from_boxed_slice` test #310

Closed kalcutter closed 1 year ago

kalcutter commented 3 years ago

This is a trivial improvement to the test. Please merge.

kalcutter commented 1 year ago

@Jasper-Bekkers Please consider this trivial change that improves a test. The test asserts that the deallocation has the correct layout. This PR also makes sure that the deallocation actually happens.

Jasper-Bekkers commented 1 year ago

Will do, could you elaborate a bit more on why this change is needed, i have very little context for this test. Code looks simple enough to just merge in though.

kalcutter commented 1 year ago

I am the original author of this test. You can find the relevant PR here: https://github.com/erickt/rust-zmq/pull/301

After it was merged, I realized the test would have been slightly better with this added assert so I made this PR.