Upgrade to `zmq2` - Githubissues

erickt / rust-zmq

Rust zeromq bindings.

Apache License 2.0

886 stars 189 forks source link

Upgrade to `zmq2` #345

Closed Jasper-Bekkers closed 1 year ago

Jasper-Bekkers commented 2 years ago

This mainly fixes a lot of build issues we were having building cross platform libraries for zmq. It's quite a few commits, but we've been running with this in production ever since the other crate got released more or less (which, for us, means we've tested Linux and Windows, not macOS).

This also updates the crate to point to the latest upstream release.

martynp commented 1 year ago

Any movement on getting this merged?

I use a small corner of ZMQ with Rust, probably not enough to be majorly useful against the full feature set of ZMQ - but am happy to look at test, review, CI etc. if I can be of help.

Jasper-Bekkers commented 1 year ago

Please do, this PR is actively looking for reviews @martynp

Jasper-Bekkers commented 1 year ago

Spent some time on this PR again;

Renamed all the zmq2 stuff back to zmq since we're moving to this crate
Most of the remaining changes are clippy fixes, crate updates, updates to CI infrastructure etc, nothing too major (moving away from Travis for example)

guenhter commented 11 months ago

Hi, I know this is already some time ago, but @Jasper-Bekkers could you shortly elaborate why the vendored feature had to go?