erickutcher / httpdownloader

HTTP(S) download manager that uses input/output completion ports (IOCP).
https://erickutcher.github.io/#HTTP_Downloader
571 stars 62 forks source link

Progress Bars Colours #110

Closed smaragdus closed 4 years ago

smaragdus commented 4 years ago

I updated from version 1.0.2.9 to version 1.0.3.0 without changing any settings in program options yet the progress bar colours are different:

Screens:

HTTP Downloader 1.0.2.9 - progress bar in task bar:

HTTP Downloader 1 0 2 9 - 2020-01-19 - 001

HTTP Downloader 1.0.2.9 - progress bar in system tray:

HTTP Downloader 1 0 2 9 - 2020-01-19 - 002

HTTP Downloader 1.0.2.9 - progress bar in URL drop window:

HTTP Downloader 1 0 2 9 - 2020-01-19 - 003

HTTP Downloader 1.0.3.0 - progress bar in task bar:

HTTP Downloader 1 0 3 0 - 2020-01-19 - 001

HTTP Downloader 1.0.3.0 - progress bar in system tray:

HTTP Downloader 1 0 3 0 - 2020-01-19 - 002

HTTP Downloader 1.0.3.0 - progress bar in URL drop window:

HTTP Downloader 1 0 3 0 - 2020-01-19 - 003

Is this change intentional? Or the problem is in my system? I prefer unified progress bar colours.

erickutcher commented 4 years ago

Yes this is intentional. The colors can be changed in the Appearance options. The Progress Color and Border Color for Downloading, Paused, and Failed downloads are used for the tray icon and URL drop window.

I see your point about making them consistent with the OS. I overlooked that. Perhaps I'll make them separate color options in the next version. And I'll have their defaults set to match the system's.

smaragdus commented 4 years ago

@erickutcher

Perhaps I did not explain well enough what I meant. What I was wondering was why the progress bar for downloading was green in task bar and violet in system tray and in URL drop window. The status is one and the same- downloading, yet the colours are 2- green for task bar, violet for system tray and in URL drop window. I think it should be either green or violet. Perhaps I am missing something?

erickutcher commented 4 years ago

The taskbar colors can only be green, yellow, or red. Windows dictates that. The tray icon and URL drop window progress colors can be anything. In prior versions I had the colors set to the same values that Windows uses. In the latest version the colors match the values that are used in the main window.

I've added some settings to the Appearance options that'll allow you to set the tray icon and URL drop window progress colors separately from the main window progress colors. By default, the values will be the same as what Windows uses.

options

smaragdus commented 4 years ago

@erickutcher

The taskbar colors can only be green, yellow, or red. Windows dictates that.

Actually I was not aware of that. If I were I would not have opened this issue. I would have preferred violet everywhere but unfortunately it is not possible for the progress bar in task bar.

I've added some settings to the Appearance options that'll allow you to set the tray icon and URL drop window progress colors separately from the main window progress colors. By default, the values will be the same as what Windows uses.

I rarely see the progress bar in task bar because HTTP Downloader usually stays hidden in system tray, If I knew that Windows did not allow other colours than green, yellow or red I would not have opened this issue. I am really sorry that I burdened you with unnecessary work- I did not not pay enough attention to the change log. As I know now that the progress bar in task bar cannot match the values used in the main window I would keep progress bar settings as they are. I am sorry if I wasted a lot of your time.

erickutcher commented 4 years ago

It wasn't a waste. I actually prefer that the colors are separated from the main window. It's a little more flexible now.

erickutcher commented 4 years ago

The new version has 6 settings that affect the progress bar colors for the system tray icon and URL drop window. By default, they match the taskbar progress colors (green, yellow, and red).

smaragdus commented 4 years ago

@erickutcher

When I try to use 'Add to Custom Colors' command for 'Progress Color' the colour is not saved permanently in 'Custom colors'.

The procedure I tried:

Can you confirm this?

erickutcher commented 4 years ago

Yeah, I never bothered dealing with that parameter for the color picker. It's easy enough to implement.

I'll have it done for the next release. It'll take some time though because I'm overhauling the Login Manager. I'm turning it into a Site Manager that'll allow per site settings.