search

erickutcher / httpdownloader

HTTP(S) download manager that uses input/output completion ports (IOCP).
https://erickutcher.github.io/#HTTP_Downloader
558 stars 62 forks source link

crashing when you remove entries from download history (pressing spacebar after it) #158

Closed uDEV2019 closed 3 years ago

uDEV2019 commented 3 years ago

After updating to v1.0.3.9 i've found an weird behaviour (it does exist in previous versions), for example: having two entries in the download history and remove them with STRG+R and pressing Enter to confirm removal in the dialog. After that, i'm pressing the spacebar and program crashes without any error message.

Windows event log (Windows 7 x64):

Name der fehlerhaften Anwendung: HTTP_Downloader.exe, Version: 1.0.3.9, Zeitstempel: 0x607341f3 Name des fehlerhaften Moduls: HTTP_Downloader.exe, Version: 1.0.3.9, Zeitstempel: 0x607341f3 Ausnahmecode: 0xc0000005 Fehleroffset: 0x000000000003a32b

After relaunch of the program, former deleted entries are back.

Sidenote with previous version i've used (v1.0.3.6) it was possible to confirm the the removal dialog with spacebar. With v1.0.3.9 this isn't possible anymore.

erickutcher commented 3 years ago

The crash happens when the treelistview is empty and a character is typed. It's trying to search for something when there's no entries.

I replaced all of the Windows message boxes with a custom one so they may not behave exactly the same. I'll see what I can do. Edit: The default button in the message box is now focused and that'll allow space to work.

I'll have a new release up tomorrow to address all of this.

erickutcher commented 3 years ago

I've released a new version that fixes the crash and allows the space bar to work in message boxes. Thanks for the translation update too.