erickutcher / httpdownloader

HTTP(S) download manager that uses input/output completion ports (IOCP).
https://erickutcher.github.io/#HTTP_Downloader
558 stars 62 forks source link

Dark mode works only in "portable" mode #207

Closed martymarty004 closed 5 months ago

martymarty004 commented 2 years ago

I downloaded the latest DM version of HTTP Downloader (v1.0.4.9), but I found out that it only works correctly after you configure the program in Portable mode by adding the portable file where the executable is.

I use the program in portable mode, so this isn't an issue for me, but I wanted to report it anyway.

Also, I think that you should write somewhere what is the difference between the different executables (Default, DM, LS), because it wasn't clear at first.

image

image

erickutcher commented 2 years ago

I see what the problem is. The "dark_mode" file should be in the AppData folder where the settings are if you're not using portable mode. I need to change it so that it reads it from the same directory as the program.

The Dark Mode build uses unsupported API functions and so it may or may not work going forward. That's the primary reason why I haven't documented it. The Log Support build is mostly for debugging purposes and I don't expect many would need to use it.

martymarty004 commented 2 years ago

OK, thank you. Should I close this issue now, or are you going to close it with a PR?

erickutcher commented 2 years ago

I'll close it when I do a new release, but since this isn't a priority fix, it'll probably be some time from now.

erickutcher commented 2 years ago

A new version is up that should fix this.