search

erickutcher / httpdownloader

HTTP(S) download manager that uses input/output completion ports (IOCP).
https://erickutcher.github.io/#HTTP_Downloader
571 stars 62 forks source link

Adding multiple URLs with overridden filenames broken #271

Closed maliayas closed 6 months ago

maliayas commented 7 months ago

Something is weird with filename overriding. Try adding this:

[LightBulb-2.4.10.zip]https://github.com/Tyrrrz/LightBulb/releases/download/2.4.10/LightBulb.zip

[HTTP_Downloader_64-1.0.5.7.zip]https://github.com/erickutcher/httpdownloader/releases/download/v1.0.5.7/HTTP_Downloader_64.zip

Only the first one gets added. If I omit the custom filenames, it works fine.

Also try adding this:

[w64-2024-04-06-01-50-49.zip]https://github.com/justdan96/tsMuxer/releases/download/nightly-2024-04-06-01-50-49/w64.zip

[w32-2024-04-06-01-50-49.zip]https://github.com/justdan96/tsMuxer/releases/download/nightly-2024-04-06-01-50-49/w32.zip

The first one gets added fine, however the second one's custom filename is ignored.

erickutcher commented 7 months ago

The extra line between the URLs is what's causing it to fail.

Try adding them this way instead:

[LightBulb-2.4.10.zip]https://github.com/Tyrrrz/LightBulb/releases/download/2.4.10/LightBulb.zip
[HTTP_Downloader_64-1.0.5.7.zip]https://github.com/erickutcher/httpdownloader/releases/download/v1.0.5.7/HTTP_Downloader_64.zip

This will be fixed in the next release whenever I upload that. It's not critical though.

maliayas commented 6 months ago

Fixed with the last version. Thanks.