search

erickutcher / httpdownloader

HTTP(S) download manager that uses input/output completion ports (IOCP).
https://erickutcher.github.io/#HTTP_Downloader
555 stars 62 forks source link

Site Manager didn't work #305

Open ZmdnaHF0ZmFqYXZ0O opened 1 month ago

ZmdnaHF0ZmFqYXZ0O commented 1 month ago

Dear developer, I set these sites: https://*.github.com and https://*.githubusercontent.com in Site manager, and these URL will use a proxy to download, but it didn't work, when I download any files from github ( the files URL like https://github.com/DEVELOPER_NAME/PROJECT_NAME/releases/download/VERSION/FILENAMES.zip, and the files' real URL are https://objects.githubusercontent.com/github-xxxxxx ), it always direct download without the proxy, is it a issue? Thanks! image

erickutcher commented 1 month ago

I think there might be a bug with the wildcard value.

If you use https://github.com and https://objects.githubusercontent.com instead then it should work.

I'll look into this.

erickutcher commented 1 month ago

Turns out it had to do with the URL redirection. It wasn't applying the Site Manager values to the redirected URL. I think I'll add an option to apply the same proxy values for redirected URLs if the initial URL has a proxy set. But for now, this bug has been fixed.

ZmdnaHF0ZmFqYXZ0O commented 1 month ago

Thanks for your reply.

erickutcher commented 2 weeks ago

A new version is up that should have this fixed.

ZmdnaHF0ZmFqYXZ0O commented 2 weeks ago

Hi, I tried the new verion, but *.github.com still don't include github.com, thanks.

erickutcher commented 2 weeks ago

You'll need two separate entries. The wildcard only targets subdomains. That's by design, but maybe I'll have it include the main domain in a later version.