search

erickutcher / httpdownloader

HTTP(S) download manager that uses input/output completion ports (IOCP).
https://erickutcher.github.io/#HTTP_Downloader
565 stars 61 forks source link

Some feedback #62

Open t214c opened 5 years ago

t214c commented 5 years ago

Hi, how about the following?

Thanks :)

erickutcher commented 5 years ago

The sounds I want to be consistent with what the operating system uses. You might be able to mute the app in Windows somehow, but I'm not sure.

The user-agent setting would be apart of my revamp. https://github.com/erickutcher/httpdownloader/issues/59

If a file isn't found and you know it doesn't exist, then I'd just select Remove instead.

When you rename a queued download does it prompt you? It shouldn't. If it does anything beyond renaming, then it's a bug.

Changing the new line key would be inconstant with what's expected of a multi-line edit control. Plus I'm going to need it the way it is if I ever get to implementing multi-host/mirrored downloads.

The toolbar is a simple bitmap. I could probably make it so that one can be loaded from the disk.

I've thought about a speed limiter. It's not an easy thing to make. You basically have to measure the rate at which all downloads, or each download is going and then preempt their request for data. It gets messy fast. And with IOCP handling it all, my brain will probably turn to jelly. If I ever implement that, it's far far away in the future.

t214c commented 5 years ago

The sounds I want to be consistent with what the operating system uses. You might be able to mute the app in Windows somehow, but I'm not sure.

The problem is the sound becomes irritating as it accompanies practically every message. I tried your advice but couldn't find it in the volume mixer. I would otherwise have to mute that sound globally which is not ideal.

The user-agent setting would be apart of my revamp. #59

Great!

If a file isn't found and you know it doesn't exist, then I'd just select Remove instead.

When cleaning old downloads (some partial, some moved). It is easier to hit Del. The Del key is hard mapped to delete. That was another request I had in #43 for keyboard shortcut customization. :)

When you rename a queued download does it prompt you? It shouldn't. If it does anything beyond renaming, then it's a bug.

It does pop out the message.

The toolbar is a simple bitmap. I could probably make it so that one can be loaded from the disk.

I meant adding and removing buttons. For example, adding "Remove Completed" to it.

I've thought about a speed limiter. It's not an easy thing to make. You basically have to measure the rate at which all downloads, or each download is going and then preempt their request for data. It gets messy fast. And with IOCP handling it all, my brain will probably turn to jelly. If I ever implement that, it's far far away in the future.

:) Can you make use of speed limiters in other open-source software (including some torrent clients)?

erickutcher commented 5 years ago

If you can get HTTP Downloader to play a sound from one of the prompts, then it should show up in the Volume Mixer and from there you can mute it permanently. https://www.thewindowsclub.com/adjust-volume-for-individual-programs-windows

I suppose I could have Del remove a non existent download. I'll put it on my to-do list.

I just tested the queued item renaming again and I see what the problem is now. I'll have it fixed in the next release.

I'll put the toolbar organization on my to-do list also. I did end up implementing the loading of a custom toolbar. You can edit this file and place it in the same folder as the program: https://github.com/erickutcher/httpdownloader/blob/master/HTTP_Downloader/toolbar.bmp

Other speed limiters are going to be specific to the program they're implemented in. I wouldn't really be able to use them. A speed limiter is a huge undertaking that I just don't have the time to do at the moment. Perhaps in the future.

t214c commented 5 years ago

If you can get HTTP Downloader to play a sound from one of the prompts, then it should show up in the Volume Mixer and from there you can mute it permanently. https://www.thewindowsclub.com/adjust-volume-for-individual-programs-windows

I tried. It shows under System Sounds (Win 10). i.e. the global option. No HTTP Downloader item :\

I suppose I could have Del remove a non existent download. I'll put it on my to-do list.

I just tested the queued item renaming again and I see what the problem is now. I'll have it fixed in the next release.

I'll put the toolbar organization on my to-do list also. I did end up implementing the loading of a custom toolbar. You can edit this file and place it in the same folder as the program: https://github.com/erickutcher/httpdownloader/blob/master/HTTP_Downloader/toolbar.bmp

Other speed limiters are going to be specific to the program they're implemented in. I wouldn't really be able to use them. A speed limiter is a huge undertaking that I just don't have the time to do at the moment. Perhaps in the future.

Thanks. You are a nice person!

erickutcher commented 5 years ago

I just realized that it wouldn't be a good idea to delete without a prompt. In the interest of being consistent with the OS, I'd prefer there be a prompt whether a file exists or not. To keep the prompt for files that exist and ignore it for ones that don't would not be very efficient. It would require scanning for the selected files twice.

erickutcher commented 5 years ago

I tried. It shows under System Sounds (Win 10). i.e. the global option. No HTTP Downloader item :\

You need to access it through the Volume Mixer. Right click on the volume icon in the system tray and select Volume Mixer. Keep that window open and then get HTTP Downloader to ask you to rename, overwrite, or skip a file. Any one of those actions will cause a prompt that makes a sound. When it does, HTTP Downloader will show up in the Volume Mixer and you can mute it from there.

t214c commented 5 years ago

I was using the volume mixer.

Following your last comment, I triggered the overwrite prompt and it did appear then in the volume mixer. I muted it. It no longer makes a sound with that prompt.

However, what I was talking about originally was the delete prompt (Del key) or the "Remove Completed" prompt. Even after muting HTTP_D, they still makes the sound!

Maybe they are using a different channel/method?

t214c commented 5 years ago

I also noticed another thing. I will put it in a new issue.

erickutcher commented 5 years ago

The other prompts are native system prompts and the only way to mute those would be to mute the system.

Zero3K commented 5 years ago

The other prompts are native system prompts and the only way to mute those would be to mute the system.

Or set Windows to not have any audio file associated with those events.