ericlanvin / mt4tradeduplicator

Automatically exported from code.google.com/p/mt4tradeduplicator
0 stars 0 forks source link

Send OrderComment() #5

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?

OrderComments() are not sent from SENDER to RECEIVER

These are often used for more than merely comment - they may contain
essential information required to properly categorize and manage the
positions (and hence copied positions) on the RECEIVER. The comments should
be forwarded wherever possible (surely always ?)

Ideally the comments from BEFORE a partial close should be sent as the
partial close operation destroys the comment, but for now that is sugar.

If you don't send the ORIGINAL comment a very quick open and partial close
before the new position was sent would destroy the ability of the RECEIVER
to reconstruct the comment.

(Yes a know a forwarded partial close destroys the comment but not before
the RECEIVER sees the comment and can then associate the comment with the
position in the future)

Original issue reported on code.google.com by Ian.P.Jo...@btinternet.com on 22 Jan 2010 at 12:28

GoogleCodeExporter commented 9 years ago
Okay - sure, I can add this.

Original comment by dwmcqu...@gmail.com on 10 Jun 2010 at 12:47

GoogleCodeExporter commented 9 years ago
Currently being added - one issue is MetaTrader is a little finicky on arrays 
of strngs being passed.

Original comment by dwmcqu...@gmail.com on 8 Jul 2010 at 2:30

GoogleCodeExporter commented 9 years ago
Fixed

Original comment by dwmcqu...@gmail.com on 6 Oct 2011 at 2:11