ericleasemorgan / reader

Distant Reader, a tool for using & understanding a corpus
GNU General Public License v2.0
20 stars 7 forks source link

Create log in page #147

Closed ericleasemorgan closed 3 years ago

ericleasemorgan commented 3 years ago

@randal-sean-harrison needs to take @dbrower's good ORCID work, and use it as a framework for creating log in page.

dbrower commented 3 years ago

The template for the not-quite-current, but soon-to-be login page.

nkmeyers commented 3 years ago

@randal-sean-harrison the login page works but renders kinda wonky

Login using ORCID and Sign in with ORCID button with black outline render so similarly that it is hard to tell which is the label and which is the button?

can we maybe copy this sign in pane layout approach at ORCID? https://orcid.org/signin

image

image

nkmeyers commented 3 years ago

there's also code for a simple UI for obtaining authenticated ORCID iDs using OAuth with OpenID Connect https://github.com/ORCID/orcid-auth-widget

dbrower commented 3 years ago

there's also code for a simple UI for obtaining authenticated ORCID iDs using OAuth with OpenID Connect https://github.com/ORCID/orcid-auth-widget

Thanks Natalie! This looks like it is for a single-page javascript app, though. And we can't have the image with the username and password, since it is ORICD that is doing the authentication.

What if the sign-in button were restyled to be clearer, similar to how websites have a "sign-in with Google" button?

nkmeyers commented 3 years ago

@dbrower yeah, I was thinking we just lift this part and change the text to be "sign in via orcid" and a companion "regsiter/get your orcid" for people who don't have one?

Just these two buttons and the text link to go get one if you don't have one?

image

dbrower commented 3 years ago

Finished. See https://distantreader/p/login