search

ericleasemorgan / reader

Distant Reader, a tool for using & understanding a corpus
GNU General Public License v2.0
20 stars 7 forks source link

back button on annotated bibliography page returns user to keywords page #182

Open nkmeyers opened 3 years ago

nkmeyers commented 3 years ago

If I hit the back button on the annotated bibliography page to return to the "bibliographics" page I am instead returned to the "keywords" page . This is unexpected and dumps user to a page they may not have even visited yet? Not quite sure why or even how that works that way?

dbrower commented 3 years ago

This seems to be only on CORD carrels?

Steps to reproduce:

  1. Visit "bibliographics" page (in top left drop down menu). e.g. https://distantreader.org/p/carrels/journal-actaPharmacolSin-cord/htm/bibliographics.htm
  2. click "here" to see to see an annotated bibliography
  3. choose browser "back" button
dbrower commented 3 years ago

The "page" that appears giving an annotated bibliography is really a pop-up window. So hitting the back button takes you to the page you were on when selecting the "bibliographics" link.

Also it seems different searches generate different html files and some don't have this problem.

dbrower commented 3 years ago

The HTML for this page is generated on the compute side. I have been trying to not touch any of the compute code. Also, there are three forks of the compute code, so changes need to be made on each fork. Lastly, changing the compute code does not change the HTML in the carrels already created.

@ericleasemorgan do you have any thoughts on these three points? Is it ok if I change the compute code? do you have a way to deploy my changes to the compute nodes? How should HTML bugs in already created carrels be handled?