search

ericleasemorgan / reader

Distant Reader, a tool for using & understanding a corpus
GNU General Public License v2.0
20 stars 7 forks source link

layout of top banner on home page is squishing the art #187

Closed nkmeyers closed 3 years ago

nkmeyers commented 3 years ago

The layout of the top banner on the home page is squishing the art - If you know what size you want the banner art we can ask Kristina to re-work the dimensions to suit. As currently cropped/resized it sort of eats too far into her graphic design?

image

distant-reader_banner (1)

dbrower commented 3 years ago

I could reproduce this by scaling my browser window down to 10% size.

The "squishing" looks to be a side-effect of scaling the image to be the full width of the window. When the window is very wide (at the 10% setting my browser window has a logical width of ~4000 px), the image scales to be very tall. But the jumbotron element that it is inside has no text, so it is set to a minimum height of 350px and hence the image gets cut short.

Any ideas @randal-sean-harrison ?

dbrower commented 3 years ago

To fix the problem, the image was made non-streachy. This should keep it from getting cropped funny on very wide windows.