search

ericlewis / PageSheet

Customizable sheets using UISheetPresentationController in SwiftUI
MIT License
55 stars 7 forks source link

Programmatically setting detent results in clipped view. #11

Open ericlewis opened 2 years ago

ericlewis commented 2 years ago

Programmatically changing from a large detent to a medium detent causes the content view to resize to the end height, resulting in a white box as the controller moves downward to its new size.

aehlke commented 1 year ago

this is just a visual issue during the transition? or it stays in a broken state after changing from large to medium (larger to smaller)? sorry, just trying to understand what issue to expect by adopting this. thanks

ericlewis commented 1 year ago

this is just a visual issue during the transition? or it stays in a broken state after changing from large to medium (larger to smaller)? sorry, just trying to understand what issue to expect by adopting this. thanks

Quick question - why would you adopt this? All of it is now built in to SwiftUI.

aehlke commented 1 year ago

@ericlewis I rely on undimmed sheets, like you see in map apps. if I use introspection to add undimmed, it flashes to dimmed for a moment. I forked this with some little tweaks and have everything working nicely for my app now, thanks for your work.