search

ericlyon / FFTease3.0-MaxMSP

version of FFTease for Max 6.1 and later
Other
26 stars 1 forks source link

CMake-ify and add cross-platform GitHub actions #3

Closed isabelgk closed 1 year ago

isabelgk commented 1 year ago

Hi Eric,

I hope this finds you well! I'm a developer at Cycling '74 and I thought it would be helpful to submit a PR that updates this fantastic package to be in the style of Max >=8.2 packages (using CMake and max-sdk-base).

Changes with this PR:

Best, Isabel

ericlyon commented 1 year ago

Hi Isabel,

Thanks for reaching out. The 8.2 SDK is great; I just haven't had time to update my code for it, so thanks for taking the initiative! I have approved your pull request.

If you have time, it would be great if you would update LyonPotpourri https://github.com/ericlyon/LyonPotpourri3.0-MaxMSP as well. I would love to get both Mac and Windows releases for both of these repositories, and ideally, get them integrated into the Max Package Manager system. Any guidance you could provide would be much appreciated.

Best wishes, Eric

On Sat, Nov 5, 2022 at 2:07 PM Isabel @.***> wrote:

Hi Eric,

I hope this finds you well! I'm a developer at Cycling '74 and I thought it would be helpful to submit a PR that updates this fantastic package to be in the style of Max >=8.2 packages (using CMake and max-sdk-base).

Changes with this PR:

  • Removing Xcode projects and VS solutions to now use CMake (which is used to generate projects for Xcode, VS, and more)
  • Uses max-sdk-base as a git submodule, so building doesn't require downloading the SDK separately.
  • The repository to be in the shape of a Max package where docs and help patchers are included.
  • I added a GitHub actions task that should be able to build the package for both Mac and Windows via the "Actions" tab.

Best, Isabel

You can view, comment on, or merge this pull request online at:

https://github.com/ericlyon/FFTease3.0-MaxMSP/pull/3 Commit Summary

File Changes

(300 files https://github.com/ericlyon/FFTease3.0-MaxMSP/pull/3/files)

isabelgk commented 1 year ago

Sorry for the late reply and thanks for the merge! I'd be happy to take a look at the LyonPotpourri repository and see what I can do to help there. 😃

ericlyon commented 1 year ago

Awesome, Isabel.

Thanks, and Happy 2023!

Eric