search

ericlyon / pd-fftease

FFTease 3.0 for Pd
Other
18 stars 4 forks source link

residency_buffer~: use of deprected array_getfloatarray #10

Closed umlaeute closed 3 years ago

umlaeute commented 8 years ago

residency_buffer~ uses the long-deprecated array_getfloatarray() function to access tables.

it should use array_getfloatwords() instead.

umlaeute commented 8 years ago

the difference between the two functions is that the former assumes that sizeof(t_float)==sizeof(void*) which is true on the i386 platform, but not necessarily on others (most notably, it is not true on x86_64).

I'm aware that fftease3.0-32bit does not support anything but i386. Anyhow, please leave this ticket open, I will eventually submit a fix.

ericlyon commented 8 years ago

Agreed on all of this. When I last tried array_getfloatwords() I got lots of surprising failures, but this was a few years ago. Clearly a move to array_getfloatwords() will be required for the next version.