search

ericlyon / pd-lyonpotpourri

Pd version of LyonPotpourri 3.0.
Other
19 stars 5 forks source link

LyonPotpourri 3.0 - soon ready for release #14

Closed ericlyon closed 3 years ago

ericlyon commented 3 years ago

LyonPotpourri 3.0 for Pd may soon be ready for release. All of the help files have been rewritten, and several bugs have been fixed in the process. Now the externals need to be kicked around to see if there are any crashes, errors in the help files, or other issues that would be a problem for users. @porres and @Lucarda, it would be great if you are able to take a look.

There are some longer-term issues with the code, which currently has a lot of cruft that needs to be trimmed, but that's not a concern for this release, unless it causes an issue that a user would notice. It would be great to get v3.0.0 out the door in the coming week.

Lucarda commented 3 years ago

Cool. I'll start building and testing on Windows and Linux.

ericlyon commented 3 years ago

Thanks, @Lucarda, for updating the help files. I further updated a few of them, mainly where I had previously forgotten the "lyonpotpourri" prefix. I'm thinking to leave a couple days to play around with the externals, and if there are no horrible problems, then onto the official v3.0.0 release.

porres commented 3 years ago

test binaries? :)

ericlyon commented 3 years ago

test binaries? :)

That is the way.

porres commented 3 years ago

I'm trying to achieve a new icon patch with colors that hopefully everybody will find more aesthetically pleasent :)

ericlyon commented 3 years ago

I'm trying to achieve a new icon patch with colors that hopefully everybody will find more aesthetically pleasent :)

Happy to have a look at your suggestion, though no promises that I will like it better :)

Lucarda commented 3 years ago

May be some space to the left must be added to the holding rectangle.

This is how it renders on Windows:

windows

and on Linux:

linux

ericlyon commented 3 years ago

That's interesting. Looks great on Mac, so it sounds like we need extra space on both sides. Or is it a font issue? Screen Shot 2021-03-15 at 1 54 50 PM

ericlyon commented 3 years ago

In any case, please make a version with enough space to fit on Windows & Linux, and attach here. I'll give it a try on Mac, and if it looks good there too, I'll update in the distro. Thanks!

Lucarda commented 3 years ago

Yes is a font issue. Recently macOS switched to use the "Menlo" font. Windows and Linux use "DejaVuSansMono-Bold".

I'll try and push.

porres commented 3 years ago

Yes is a font issue. Recently macOS switched to use the "Menlo" font.

but that was a fix rather than something that introduced a bug. Menlo should act like DejaVu... let's take this to the pd list/github

ericlyon commented 3 years ago

Yes is a font issue. Recently macOS switched to use the "Menlo" font.

but that was a fix rather than something that introduced a bug. Menlo should act like DejaVu... let's take this to the pd list/github

Cool. Meanwhile, let's get the spacing issue fixed for our upcoming release of LyonPotpourri.

Lucarda commented 3 years ago

Please wait. I can no longer push. I was doing it with my password until now but since i created a token i cant push any more. Will try a fork.

ericlyon commented 3 years ago

Yes, please use a PR. Thanks!

Lucarda commented 3 years ago

20 look like this on Windows:

win2

ericlyon commented 3 years ago

I can see that a few of the help files will need to be adjusted, where overlaps have been introduced with the text to the right. Would you like to take care of that, or should I?

Lucarda commented 3 years ago

I'll do it. :)

Lucarda commented 3 years ago

While working on #21 I found that granulesf~ is missing the initial description.

ericlyon commented 3 years ago

Please use this one: - sound file granulator

Lucarda commented 3 years ago

Please use this one: - sound file granulator

done.

ericlyon commented 3 years ago

Looks like we're really close now. I'll create a release tag on Wednesday. If no major problems emerge by then, it will go out that day. Thanks for all of your help on this!

Lucarda commented 3 years ago

Ok, so no freeze and test binaries then? I'm Ok without them.

ericlyon commented 3 years ago

I'm not planning to update the code unless a nasty bug emerges.

Lucarda commented 3 years ago

a "nasty bug" my emerge if people can test it. :) We might give them binaries?

ericlyon commented 3 years ago

That's what v3.0.1 is for :)

Lucarda commented 3 years ago

Ok then. We are done until Wednesday. :)

ericlyon commented 3 years ago

You can still try to make the objects crash until Wednesday :)

ericlyon commented 3 years ago

Just created the v3.0.0 tag. Please send binaries for this release. Thanks @Lucarda & @porres!

Lucarda commented 3 years ago

@ericlyon the binaries are here

Do I upload to Deken or you (or @porres) do it?

ericlyon commented 3 years ago

@ericlyon the binaries are here

Do I upload to Deken or you (or @porres) do it?

Please send me the binaries, and I'll put them up in the release. You guys can take care of Deken however you like. Thanks!

Lucarda commented 3 years ago

Please send me the binaries, and I'll put them up in the release.

They are in the "here" link on my previous post. :)

Lucarda commented 3 years ago

I'll upload to Deken.

ericlyon commented 3 years ago

Great! I think we're sorted for v3.0.0 then.

Lucarda commented 3 years ago

Yes it's done!!!

Can you test geting the lib from deken?

I'm going to dinner. :)

ericlyon commented 3 years ago

Yes it's done!!!

Can you test geting the lib from deken?

I'm going to dinner. :)

Yep, works from a Mac computer.

Lucarda commented 3 years ago

I had also checked the other OS/archs Deken packages and they are also Ok.

Pd-list announcement?

(looks that this issue can be closed)

:)

ericlyon commented 3 years ago

I had also checked the other OS/archs Deken packages and they are also Ok.

Pd-list announcement?

Sure - go for it! Cheers,Eric