search

ericlyon / pd-lyonpotpourri

Pd version of LyonPotpourri 3.0.
Other
19 stars 5 forks source link

no clock_free called for clocks in click2bang~, click2float~, sigseq~, or splitspec~ #2

Closed sebshader closed 3 years ago

sebshader commented 3 years ago

the clocks aren't freed when the objects are destroyed/freed. This can cause pd to crash with a segfault when the object is destroyed since the clock is still on the scheduling list and will reference items in the object when it calls the callback

ericlyon commented 3 years ago

Thanks for the report. I just updated click2bang~. Please let me know if there are any side effects. If not, I'll fix the other affected objects.

sebshader commented 3 years ago

@ericlyon I only found the bug with click2float~. However, I think click2bang~ looks good except that I think clock_free needs to be used instead of free, in order to free the clock (bc clock_free will call clock_unset, which is what will take it off of the scheduling list)

ericlyon commented 3 years ago

Updated click2bang~. The other three objects still require this fix.

ericlyon commented 3 years ago

All four externals updated with clock_free().

sebshader commented 3 years ago

@ericlyon does click2float~ still need it?

ericlyon commented 3 years ago

Forgot to upload the new files. Should be fine now.