search

ericm / stonks

Stonks is a terminal based stock visualizer and tracker that displays realtime stocks in graph format in a terminal. See how fast your stonks will crash.
https://stonks.icu
GNU General Public License v3.0
548 stars 35 forks source link

Refactor graphs package #28

Closed volmedo closed 2 years ago

volmedo commented 2 years ago

Closes #23

All the logic to create the graph is currently living in a single function. Let's break it into smaller, easier to understand functions and make other improvements along the way.

volmedo commented 2 years ago

@ericm the PR is now ready for review. There are probably some other improvements that could be done, but I think the current changes already make a significant difference in terms of readability and maintainability.

PTAL and let me know what you think.

ericm commented 2 years ago

Could you fix the macos build? https://github.com/ericm/stonks/actions/runs/3257662825/jobs/5349081348

volmedo commented 2 years ago

I already did! 🙂 We need to merge this other PR first. I decided to get it sorted in a different PR since it wasn't directly related with the refactor.

ericm commented 2 years ago

That or should be approved now. Rebase on top of master 😀