search

ericm / yup

Arch Linux AUR Helper with ncurses functionality and better searching and sorting
https://aur.archlinux.org/packages/yup
GNU General Public License v3.0
139 stars 7 forks source link

Viewing diffs for a package with update fails #11

Closed ftsell closed 5 years ago

ftsell commented 5 years ago

I recently tried out yup and just used it do do updates.

After printing the PKGBUILD of a package which has an available update it asks me what to do. I chose see Diff by pressing D after which it generated the following output:

==> View, see Diffs or Edit the PKGBUILD? (All or None): D
fatal: ambiguous argument '@~..@': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
==> Continue?:

It should be noted that the directory yup tries to do the diff in was previously managed by yay as that is my current main package manager.

ericm commented 5 years ago

I'll look into this

On 19 Jul 2019, 17:07, at 17:07, Finn-Thorben Sell notifications@github.com wrote:

I recently tried out yup and just used it do do updates.

After printing the PKGBUILD of a package which has an available update it asks me what to do. I chose see Diff by pressing D after which it generated the following output:

==> View, see Diffs or Edit the PKGBUILD? (All or None): D
fatal: ambiguous argument '@~..@': unknown revision or path not in the
working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
==> Continue?:

It should be noted that the directory yup tries to do the diff in was previously managed by yay as that is my current main package manager.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/ericm/yup/issues/11

ericm commented 5 years ago

Could you show me some steps to reproduce this?

Atemu commented 5 years ago

Could it be that this happens when there is no difference? (version bump or automatic version bump from -git package)

ericm commented 5 years ago

I've reinstalled packages before and never got that message. What package were you syncing?

Atemu commented 5 years ago

Reinstalling works for me too, it just shows nothing instead of the diff, have you tried upgrading from an older version?

One package I just had this error with was upgrading https://aur.archlinux.org/packages/based-connect-git/, I had a few others aswell but those are too far back in the terminal buffer now and I don't remember which ones. Is there a log somewhere maybe?

Anyways, this was just a hunch because I never saw an empty diff while upgrading a bunch of -git packages that yay didn't even notice (nice one yup!) and bumps with no changes should be quite common.

Just found out how to repro, try to install packages like based-connect-git without it being present in the yup cache.
It works for some and not for others (works for auracle-git for example. It shows the diff of the commit you're trying to install vs. the commit before it in the AUR git repo btw, not the commit of the currently installed version, is this intended?).
There is only one commit for based-connect-git in the AUR git repo, maybe that has something to do with it.

ericm commented 5 years ago

There is only one commit for based-connect-git in the AUR git repo, maybe that has something to do with it.

That's it i'd say. git diff @~..@ only works on branches with multiple commits. I'll just add a command error check in the next update.