search

ericma2014 / mp4v2

Automatically exported from code.google.com/p/mp4v2
Other
0 stars 0 forks source link

trivial bug in win32 platform layer #89

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Hi,

Found trivial bugs in win32 platform layer;

1) platform_win32.cpp is missing from GNUmakefile.am
2) in libplatform/io/FileSystem_win32.cpp:

   in some functions, these lines:
        log.errorf("%s: GetFileAttributesExW(%s) failed (%d)",
        __FUNCTION__,filename.utf8, GetLastError());

   should be rewritten like the following:
        log.errorf("%s: GetFileAttributesExW(%s) failed (%d)",
        __FUNCTION__,filename.utf8.c_str(), GetLastError());

   That is, filename.utf8 is not char* but std::string, therefore
   cannot be directly passed to log.errorf().

Original issue reported on code.google.com by honeycom...@gmail.com on 27 Mar 2011 at 10:09

GoogleCodeExporter commented 9 years ago 
You're right.  Fixed in r458.

Original comment by dbyr...@gmail.com on 27 Mar 2011 at 2:30