search

ericmandel / pyds9

Python connection to SAOimage DS9 via XPA
76 stars 41 forks source link

devel branch? #23

Closed montefra closed 8 years ago

montefra commented 8 years ago

Before I start reshaping the repository #19 and moving the setup script from distutils to setuptools #18 I would like to share some thought.

At the moment we don't have pyds9 on PyPI, so people are likely using the master branch as "stable" installation.

The above changes are substantial and might break something. Plus I would prefer to present the changes all at once to the users.

So I'm thinking to start a devel branch and to develop #18 and #19 against it. Once they'll be ready and we'll be satisfied, I'll merge devel into master and call it a release.

At that point we can go on PyPI. The versions there will be the stable ones and all the development can proceed against master as usual.

Any comment?

ericmandel commented 8 years ago

I think this is a good idea, mainly in order to allow you to present all changes at once. I don't know that a devel branch would get enough traffic to "prove" that everything works properly -- instead, it might give you a false sense of security. But I do think there is a lot of good reason to make a branch that you can play with and build up slowly before making a commit to the master. So, in sum, I think you should do this.

On Wed, Sep 23, 2015 at 12:54 PM, Francesco Montesano < notifications@github.com> wrote:

Before I start reshaping the repository #19 https://github.com/ericmandel/pyds9/issues/19 and moving the setup script from distutils to setuptools #18 https://github.com/ericmandel/pyds9/issues/18 I would like to share some thought.

At the moment we don't have pyds9 on PyPI, so people are likely using the master branch as "stable" installation.

The above changes are substantial and might break something. Plus I would prefer to present the changes all at once to the users.

So I'm thinking to start a devel branch and to develop #18 https://github.com/ericmandel/pyds9/issues/18 and #19 https://github.com/ericmandel/pyds9/issues/19 against it. Once they'll be ready and we'll be satisfied, I'll merge devel into master and call it a release.

At that point we can go on PyPI. The versions there will be the stable ones and all the development can proceed against master as usual.

Any comment?

— Reply to this email directly or view it on GitHub https://github.com/ericmandel/pyds9/issues/23.

cdeil commented 8 years ago

@montefra – If you really think "people are likely using the master branch as "stable" installation", why not tag master and make a release on PyPI right now? And then continue development in master like pretty much all project on Github?

But that's just my 2 cents ... in the end I don't think it matters in which branch you develop in the near future ... the important thing is that it's happening at all. Thank you, @montefra!

montefra commented 8 years ago

@ericmandel:

to "prove" that everything works properly -- instead, it might give you a false sense of security.

There is only one way for it: unit tests. Independently of the branch name. We will work on it, eventually.

@cdeil : I would personally wait to have the code organized in a more standard way and that uses setuptools before going to PyPI.

ericmandel commented 8 years ago

the important thing is that it's happening at all. Thank you, @montefra!

I fully agree!

montefra commented 8 years ago

done

montefra commented 8 years ago

This is a check list for me to check what I should do and for whoever wants to follow/comment:

montefra commented 8 years ago

Now that pyds9 is back in a usable state, I've merged devel into master and I'll keep working from there.