ericmandel / pyds9

Python connection to SAOimage DS9 via XPA
76 stars 41 forks source link

Replace find_executable with shutil.which #71

Closed olebole closed 5 years ago

olebole commented 5 years ago

find_executable is not available anymore under Python 3.7 (however I have no idea when it disappeared).

montefra commented 5 years ago

@olebole : thank you for the PR. Recently I haven't had much time to keep the repo updated and pytest overtook me. And I have done almost no python in the last 6 months :cry:

If it is not a problem for you, I can use this PR to fix the pytest problems. Then I hope to find some time to fix the remaining issues with the Travis builds.

olebole commented 5 years ago

No problem; the PR was just to save the change I made in the Debian package. I am even not really sure how it behaves on Python 2.7 (we dropped the Py2 pyds9 package recently).

montefra commented 5 years ago

python2.7 doesn't have shutil.which but it would be easy enough to handle.

Let me think about how to handle this. I'm not sure that I can push on your branch, but I don't think that I have tests against py3.7 yet, so I should be able to fix pytest. Tomorrow evening I should have some time.