search

ericmandel / pyds9

Python connection to SAOimage DS9 via XPA
76 stars 41 forks source link

Pyfits and astropy.io.fits #73

Closed fmerges closed 4 years ago

fmerges commented 5 years ago

Hello,

I can see on the top of the file, it's importing from astropy.io the fits module, but later on in the code there are references to pyfits module, and two methods that uses it.

Shouldn't this be refactored?

https://github.com/ericmandel/pyds9/blob/c1bf67ab195bd7eb0c662755c2df35df014482b0/pyds9/pyds9.py#L121-L130

Cheers,

Florian

montefra commented 5 years ago

This is more or less legacy code for the time before astropy.io.fits exists. The get_pyfits and set_pyfits methods uses pyfits if found, otherwise fall back to astropy's fits.

I think that the refactoring will be to eventually remove pyfits

DougBurke commented 4 years ago

Closed by #87