search

ericmandel / pyds9

Python connection to SAOimage DS9 via XPA
76 stars 41 forks source link

Update pyds9.py to search for saoimageds9.app #94

Closed mileslucas closed 4 years ago

mileslucas commented 4 years ago

Newer versions of DS9 ship the app as SAOImageDS9.app instead of SAOImage DS9.app. This change allows finding the first of the two (defaulting to the newer version, so as to default to a newer version of DS9) and using that for the ds9 executable.

mileslucas commented 4 years ago

I have no idea how to add this into CI, but I can confirm it works with the following set up:

$ brew cask info SAOImageDS9
saoimageds9: 8.1
http://ds9.si.edu/site/Home.html
/usr/local/Caskroom/saoimageds9/8.1 (461B)
From: https://github.com/Homebrew/homebrew-cask/blob/master/Casks/saoimageds9.rb
==> Name
SAOImage DS9
==> Artifacts
SAOImageDS9.app (App)

$ python --version
Python 3.7.4

$ sw_vers
ProductName:    Mac OS X
ProductVersion: 10.15.3
BuildVersion:   19D76
ericmandel commented 4 years ago

@mileslucas Thanks very much for doing this. Your code looks correct, but I probably should test it before merging, right? Give me a few days ... and thanks again!

DougBurke commented 4 years ago

@wjoye - are "SAOImageDS9.app" and '"SAOImage DS9.app"` the only two names used by DS9's aqua version?

ericmandel commented 4 years ago

@mileslucas Thanks for doing this, I've tested and merged.